[MPlayer-dev-eng] [PATCH] Remove workaround for va_start/vsnprintf

Diego Biurrun diego at biurrun.de
Sat Mar 1 10:05:45 CET 2008


On Fri, Feb 29, 2008 at 01:22:27PM +0100, Diego Biurrun wrote:
> On Fri, Feb 29, 2008 at 01:08:01PM +0900, KO Myung-Hun wrote:
> > 
> > There is no need to workaround for va_start/vsnprintf on OS/2 any more,
> > even it break compilation.
> > 
> > --- mp_msg.h	(revision 26113)
> > +++ mp_msg.h	(working copy)
> > @@ -111,12 +111,6 @@
> >  
> > -#ifdef __OS2__
> > -// va_start/vsnprintf seems to be broken under OS2 :(
> > -#define mp_msg(mod,lev, fmt, args... ) do{if((lev)<=mp_msg_levels[mod]) printf( fmt, ## args );}while(0)
> > -#define mp_dbg(mod,lev, args... ) 
> > -#else
> > -
> >  #ifdef __GNUC__
> >  void mp_msg(int mod, int lev, const char *format, ... ) __attribute__ ((format (printf, 3, 4)));
> >  #   ifdef MP_DEBUG
> > @@ -135,6 +129,4 @@
> >  
> >  const char* filename_recode(const char* filename);
> >  
> > -#endif /* __OS2__ */
> 
> This patch is wrong, you are removing only a part of the __OS2__
> section.  Or do you wish to keep the __GNUC__ section?  Then it has to
> be kept within __OS2__.

Never mind, I misread.  Will apply the patch in a moment.

Diego



More information about the MPlayer-dev-eng mailing list