[MPlayer-dev-eng] squelch some warnings (patches incl.)
Diego Biurrun
diego at biurrun.de
Sat Mar 8 21:25:41 CET 2008
On Fri, Feb 29, 2008 at 12:48:36AM +0100, Michael Niedermayer wrote:
> On Tue, Feb 26, 2008 at 07:00:03PM +0100, Diego Biurrun wrote:
> > On Mon, Feb 25, 2008 at 03:20:20AM +0100, Michael Niedermayer wrote:
> > >
> > > Cleanup to snow is welcome, some examples:
> > > * normalize {} placement
> >
> > Elaborate what you mean, this is ambiguous, i.e. I'm not sure what your
> > preference is.
>
> NOT:
> for(x=0; x<w; x++)
> {
> line[x] -= 128 << FRAC_BITS;
> // buf[x + y*w]-= 128<<FRAC_BITS;
> }
>
> but:
> for(x=0; x<w; x++){
> line[x] -= 128 << FRAC_BITS;
> // buf[x + y*w]-= 128<<FRAC_BITS;
> }
>
> but please dont change {} for functions, they can be:
> static void slice_buffer_flush(slice_buffer * buf)
> {
> int i;
> for (i = 0; i < buf->line_count; i++){
> if (buf->line[i])
> slice_buffer_release(buf, i);
> }
> }
>
>
> >
> > The rest is done,
>
> not really:
> return;
> }
>
> for(mb_x=0; mb_x<=mb_w; mb_x++){
> add_yblock(s, 1, sb, old_buffer, dst8, obmc,
>
> ----
> if(sliced){
> s->dsp.inner_add_yblock(obmc, obmc_stride, block, b_w, b_h, src_x,src_y, src_stride, sb, add, dst8);
> }else
> for(y=0; y<b_h; y++){
>
> ...
>
>
> > your turn now :)
>
> done
Should all be done now.
Diego
More information about the MPlayer-dev-eng
mailing list