[MPlayer-dev-eng] [PATCH] -priority support on OS/2

[Dave Yeo]

On 03/22/08 04:03 am, KO Myung-Hun wrote:
> Hi/2.
> 
> This patch implement '-priority' option on OS/2.
[...]
> +} priority_presets_defs[] = {
> +  { "realtime", MAKESHORT(0, PRTYC_TIMECRITICAL)},
> +  { "high", MAKESHORT(PRTYD_MAXIMUM, PRTYC_REGULAR)},
> +  { "abovenormal", MAKESHORT(15, PRTYC_REGULAR)},
> +  { "normal", MAKESHORT(0, PRTYC_REGULAR)},
> +  { "belownormal", MAKESHORT(PRTYD_MAXIMUM, PRTYC_IDLETIME)},
> +  { "idle", MAKESHORT(0, PRTYC_IDLETIME)},
> +  { NULL, MAKESHORT(0, PRTYC_REGULAR)} /* default */
> +};

I wonder if perhaps "high" should be foreground server, eg perhaps 4,15?
And "abovenormal" 31, PRTC_REGULAR? This would leave only normal and
abovenormal subject to dynamic priority boosts and smoother operations
if someone chooses high. At that I'd consider MPlayer important enough
that perhaps normal in this context should have some priority boost so
even "normal" being a bit high, eg 2,15 and "belownormal" being actual
normal, 2,0.
It is hard to imagine wanting to run it at 1,31 as any other process
running at normal would preempt it though for a large mencoder job it
may make sense.
Dave