[MPlayer-dev-eng] [PATCH] add support of compression algorithm 3 in mkv demuxer

[Ivan Kalvachev]

On Fri, May 9, 2008 at 1:22 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> Diego Biurrun wrote:
>
>> On Fri, May 09, 2008 at 04:19:55AM +0400, Evgeniy Stepanov wrote:
>> > On Friday 09 May 2008 03:12:42 Aurelien Jacobs wrote:
>> > > I'm sorry, but I've put on hold all my mplayer work (including
>> > > patches review), until root finally take a decision about
>> > > the "Uoti case". So please be patient.
>> >
>> > Does it mean that you are blocking all the work on demux_mkv and
>> > anything else you maintain? If not, I could commit the patch. I see
>> > nothing wrong with it.
>>
>> Careful, Aurelien is on the record for getting "angry" if you do so
>> much as add a few consts to "his" code.
>
> Weren't you the one who stated he wants to avoid flames ?
> So I will try to avoid flames, and just state it once and clearly,
> for those who may have a doubt:
>  I have nothing against one adding a few consts to "my" code, I have
> never complained about this and I will never complain about this.

The commit in question is r26412. The problem with this commit is not
that Uoti have added few consts, but that with the very same commit he
indented the tables these consts belong.
Mixing functional with cosmetic changes.


Aurelien, I have mixed feelings about this strike. On one side I am
happy that you are going to such lengths defending what is right.
On the other side I'm afraid Diego doesn't give a shit about you and
it would be best for him if you voluntarily step out of the project.

Please make full review of the patch, point what could be improved. I
think we can wait for updated patch that works with your sample too.
Delay the commit few more days to give Diego some time to think.