[MPlayer-dev-eng] [PATCH] mkv chapters and linked segments

[compn]

On Wed, 28 May 2008 11:27:29 +0200, "Fredrik Nilsson" <esserex at gmail.com> wrote:
>Hi.
>This is a patch that loads mkv chapters from external files.
>It does this by loading the extra files into separate tracks and switches to
>them when the chapter changes. Changes in mplayer.c and demuxer.c makes
>mplayer switch chapters automatically at end of chapter.
>
>To switch tracks I use a function in mplayer.c to reset decoders,
>an ugly hack but I see no simple solution to this.

wouldnt this make sense in case the next track/chapter was a different codec?

>
>I have looked into using libavformat but I see no way of implementing chapters
>or decoder change without changing the libavformat interface.
>
>Thoughts?
>
>Fredrik

huge patch. smaller patches are reviewed more quickly

dvd and mkv chapter support was merged a few weeks/months ago
do your changes affect dvd chapter support at all? does -chapter 3-5 still work? (play chaps 3-5 then stop)

assuming any of this is accepted, should linked chapters be disabled by default? it looks like you got it working for mencoder, where encoding extra things by default might not be the right/consistent thing to do.

-compn