[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Tue, Nov 18, 2008 at 11:01 AM, Guillaume POIRIER <poirierg at gmail.com> wrote:
>>> @@ -3536,34 +3550,31 @@
>>> -cat > $TMPC <<EOF
>>> -#include <Carbon/Carbon.h>
>>> +  cat > $TMPC <<EOF
>>> +#include <Cocoa/Cocoa.h>
>>>  #include <QuartzCore/CoreVideo.h>
>>> +#include <OpenGL/OpenGL.h>
>>>  int main(void) { return 0; }
>>>  EOF
>>> -     if cc_check -framework Carbon -framework QuartzCore -framework OpenGL; then
>>> +     _tmp_CFLAGS="$CFLAGS"
>>> +     CFLAGS="$CFLAGS -x objective-c"
>>
>> Does the check fail without this?
>
> Without what? I'm sorry but I'm not sure I get what you refer to by "this".
>
>
>>  And why do you use a temporary
>> variable..
>>
>>
>>> +     if cc_check -framework Cocoa -framework QuartzCore -framework OpenGL -framework Carbon; then
>>
>> ..when you can just add the flag to the compiler call here?
>
> Right, that's easy to fix...


I tested to pass -x objective-c to cc_check and it doesn't work.
That's probably because -x option is sensitive to its place on the
command line.
As you probably saw, the temporary is to modify the CFLAGS temporarily
before running the cc_check, then restoring the CFLAGS to their
original.

Anyay, the attached patch removes some more cosmetics from Gregor's
original patch.

Since I haven't heard a thing from any OSX devels from MPlayer dev
team, I shall start pushing these changes to MPlayer dev tree soonish.

Guillaume
-- 
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
 -- Pierre Desproges
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quartz-quickdraw-deprecated.3.patch
Type: application/octet-stream
Size: 19095 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081119/e19b60d2/attachment.obj>