[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Uoti Urpala]

On Wed, 2008-11-19 at 22:52 +0100, Reimar Döffinger wrote:
> On Wed, Nov 19, 2008 at 11:20:36PM +0200, Uoti Urpala wrote:
> > On Wed, 2008-11-19 at 22:58 +0200, Georgi Petrov wrote:
> > > I've changed the name of all variables and functions according to your
> > > coding style. It wasn't easy, but I want to follow MPlayer's coding
> > > style as close as possible.
> > 
> > If you're really trying to use a standard style "as close as possible"
> > there are a couple of other things:
> 
> While the priv thing has its merits I can't really see much point in all
> these cosmetics,

Consistent coding style does have advantages. 

>  you can't change the direct3d code so it will stick out
> like a sore thumb either way, either it is inconsistent with the
> D3D/Windows stuff or with the MPlayer stuff.
> And there should really be very little code left that does not involve
> D3D calls.

What "direct3d code" are you talking about? The only effect that
external code has on the MPlayer file is limited to symbol names, which
weren't related to the style issues I mentioned. Or are you talking
about consistency of MPlayer code with some outside code?

> The panscan stuff really is not supposed to stay as it is, and the idea
> of committing was only to make development easier, not for everyone to start their
> favourite bikeshed after the fact, creating extra work for everyone but
> themselves.

IMO your comments about "favourite bikeshed after the fact" and "create
extra work for everyone but themselves" are groundless and unnecessarily
hostile. Consistent coding style is not a "bikeshed", and the author of
the code was already talking about it. Overall you complain about
smaller issues than I do. So if I sometimes mention an issue you don't
particularly care about yourself it does IMO not justify such hostility.