[MPlayer-dev-eng] MNG support for MPlayer

[compn]

On Mon, 15 Sep 2008 11:42:06 +0200, Stefan Schuermans wrote:
>
>Hello MPlayer developers,
>
>MNG animations do not seem to be supported by MPlayer 1.0rc2. Because I
>wanted to play back MNG animations using MPlayer, I tried to implement a
>demuxer in libmpdemux using libmng 1.0.9 (on Debian etch).
>
>It worked out and I've been able to play the MNG animations using the
>new demuxer. Perhaps the code is useful for other people, so I'm sending
>the patchfile.
>
>Best regards,
>Stefan

nice work. please wait for our demuxer maintainer.
libmpdemux is being slowly obsoleted, but rxt said he wouldnt
reject demuxers that passed review.

nico reviewed your patch in july when you first sent it.
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2008-July/058145.html
could you address those small issues?

>[MPlayer-1.0rc2-mng20080914.diff  text/x-patch (19.0KB)]
>diff -r -N -U 3 MPlayer-1.0rc2/configure MPlayer-1.0rc2-mng20080914/configure
>--- MPlayer-1.0rc2/configure	2008-08-30 19:41:35.000000000 +0200
>+++ MPlayer-1.0rc2-mng20080914/configure	2008-08-30 

can you please diff this against current svn ?

>+/*
>+ * MNG file parser for MPlayer
>+ * by Stefan Schuermans <stefan at blinkenarea.org>
>+ */
>+

missing standard mplayer license header (please copy and paste from any
mplayer file).

the amount of source comments is tremendous! i think your code
could be used as a tutorial of how to add a demuxer into mplayer.
similar to the ffmpeg demuxer howto in the multimedia wiki.

-compn