[MPlayer-dev-eng] MNG support for MPlayer

[Uoti Urpala]

On Wed, 2008-09-17 at 23:48 +0200, Diego Biurrun wrote:
> On Wed, Sep 17, 2008 at 09:50:46AM +0200, Stefan Schuermans wrote:
> > Uoti Urpala wrote:
> > > Do you get warnings about those parameters without the attributes? If
> > > so, with what compiler/flags? GCC 4.3 does not warn about unused
> > > function parameters unless you use -Wunused-parameter or -Wextra, which
> > > are not normally set by MPlayer.
> > 
> > I get those warnings due to the "-W" flag used after "configure 
> > --enable-debug".

Yes -W is the old name for -Wextra. I didn't remember the configure
debug switch enabled extra warnings as I've been doing all debug
compiles without using it.

> I guess that -Wnounused-parameter should be added then.  Anybody
> against?

I think it should be added if -Wextra is used (and I think the option
spelling should be changed from -W to -Wextra at the same time). Is
there much reason for the warning flags to be different for debug
builds?