[MPlayer-dev-eng] MNG support for MPlayer

Diego Biurrun diego at biurrun.de
Fri Sep 19 00:11:05 CEST 2008


On Thu, Sep 18, 2008 at 10:47:00PM +0200, Stefan Schuermans wrote:
>
> I also removed the __attribute__((unused)), converted the code to not  
> contain any lines longer than 78 characters and corrected the typos.
>
> Regarding the issue with variable framerate, I now understood how the  
> GIF demuxer does the variable framerate and switched the MNG demuxer to  
> the same mechanism.
>
> --- configure	(revision 27638)
> +++ configure	(working copy)
> @@ -4683,6 +4687,33 @@
>  
> +echocheck "MNG support"
> +if test "$_mng" = auto ; then
> +  _mng=no
> +  cat > $TMPC << EOF
> +#include <libmng.h>
> +int main(void) {
> +  const char * p_ver = mng_version_text() ?: "";
> +  printf("libmng: %s\n", p_ver);
> +  return p_ver[0] == 0;
> +}
> +EOF
> +  if cc_check -lmng -lz $_ld_lm ; then
> +    if tmp_run ; then
> +      _mng=yes
> +    else
> +      _res_comment="no library version"
> +    fi
> +  fi
> +fi

I wonder why tmp_run is necessary?  And yes, I know that the libpng test
does it as well...

> --- libmpdemux/demux_mng.c	(revision 0)
> +++ libmpdemux/demux_mng.c	(revision 0)
> @@ -0,0 +1,528 @@
> +
> +  int header_processed;       // if header of MNG image is processed

if MNG image header is processed

> +  // whenever the libmng tells us to wait for some time

whenever libmng tells us

Your code is laboriously commented.  Possibly some of it could be
doxygenized.

Diego



More information about the MPlayer-dev-eng mailing list