[MPlayer-dev-eng] PATCH: Makefile FFMPEGFILES lacks wildcard expansion

Diego Biurrun diego at biurrun.de
Mon Apr 20 05:38:47 CEST 2009


On Mon, Apr 20, 2009 at 12:52:32AM +0200, Diego Biurrun wrote:
> On Sun, Apr 19, 2009 at 09:54:41PM +0200, Carl Fürstenberg wrote:
> > at row 793 in the Makefile, the foreach doesn't apply with the
> > wildcard function, and will thus fail for libavformat which hasn't any
> > sub directories,
> 
> What problem are you trying to solve?  It works fine here...

I could reproduce the problem now.

> > --- Makefile	(revision 29197)
> > +++ Makefile	(arbetskopia)
> > @@ -791,7 +791,7 @@
> >  
> > -FFMPEGFILES = $(foreach part, $(FFMPEGPARTS), $(part)/*.[chS] $(part)/*/*.[chS])
> > +FFMPEGFILES = $(foreach part, $(FFMPEGPARTS), $(wildcard $(part)/*.[chS]) $(wildcard $(part)/*/*.[chS]))
> 
> There is no need to use two $(wildcard) calls here.

I applied the simplified version of your patch.

Diego



More information about the MPlayer-dev-eng mailing list