[MPlayer-dev-eng] [PATCH] libbs2b: new api

[Uoti Urpala]

On Mon, 2009-04-20 at 22:45 +0400, Andrew Savchenko wrote:
> On Friday 03 April 2009, Andrew Savchenko wrote:
> > Hello,
> >
> > recently api of libbs2b was changed, according to svn log it
> > should be rather stable from r89. Audio filter update is
> > attached.
> 
> Ping. Proposed patch also applies for official libs2b-3.0.0 release 
> and fully utilizes its functionality. 
> 
> Please, review. Will apply in a weak if there are no objections.

There are no configure changes. Shouldn't the test be updated to reject
the old library version?

The documentation specifies certain parameter ranges, but the actual
code uses range defines from the library. I don't know whether those are
supposed to always stay constant; perhaps there should be some mention
of that?

+                   "[bs2b] Requested sample rate is out of bounds [%i..%i] Hz.\n"

I think this should say what the requested rate was.


Some code formatting issues that occur multiple times:

+           "[bs2b] Feed level must be in range [%i..%i], but current value is %i.\n",

You should use "%d" instead of "%i" like most of MPlayer code (and most
C code I've seen in general).

+            else
+            if (!strcmp(s->profile,"cmoy"))

"else if" should be on one line.

+                bs2b_set_level(s->filter,BS2B_JMEIER_CLEVEL);

Space missing after ",".