[MPlayer-dev-eng] [PATCH] Add DVB teletext support
Francesco Lavra
francescolavra at interfree.it
Sun Aug 2 10:18:02 CEST 2009
On Wed, 2009-07-22 at 09:53 +0000, Carl Eugen Hoyos wrote:
> Francesco Lavra <francescolavra <at> interfree.it> writes:
>
> > - moved stream/tvi_vbi.c to /libmpcodecs/dec_teletext.c
>
> Unfortunately not (svn move stream/tvi_vbi.c libmpcodecs/dec_teletext.c).
>
> I would really love to see dvb teletext support in mplayer and I can help you
> test and get the patches into an acceptable shape.
> But to get this into svn, it is absolutely needed that you either:
> - Implement dvb teletext without changing any filenames or renaming any options
> Change filenames and rename options afterwards.
> - Send patches only to rename files (but not with cp && svn rm!), more patches to
> rename/add options
> Then send a patch to implement dvb teletext.
>
> I slightly prefer the first option, but that is totally up to you.
> If you go for the second one, I will be able to test teletext.
>
> Carl Eugen
>
>
Sorry for my late reply. I see that libmpcodecs/dec_teletext.c has
already been scheduled for addition to the repository. In attachment is
a patch that removes the old file stream/tvi_vbi.c, removes
teletext-related definitions from stream/tv.h and stream/tvi_def.h and
places them in the new file libmpcodecs/dec_teletext.h, replaces
stream/tvi_vbi.c with libmpcodecs/dec_teletext.c in the Makefile and
changes some includes in related files to make the new code compilable.
A subsequent patch will be posted that makes access to teletext data
independent from the tv input layer, and finally a third patch will
actually add support for DVB teletext.
Let me know if this approach is appropriate.
Francesco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dec_teletext.diff
Type: text/x-patch
Size: 75167 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090802/856f48b5/attachment.bin>
More information about the MPlayer-dev-eng
mailing list