[MPlayer-dev-eng] [PATCH] fix libass + fullscreen switch

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Dec 18 19:09:06 CET 2009


On Fri, 2009-12-18 at 14:06 +0100, Jindrich Makovicka wrote:
> when switching from fullscreen to windowed mode and using libass for
> subtitles, a set_osd_subtitles call is performed, causing both standard
> OSD and libass subtitle to be displayed at once.

The set_osd_subtitles() call doesn't actually depend on a fullscreen
switch. The effects of the bad state just aren't visible normally.
You're correct about the call being wrong though.

> The attached patch
> also adds a libass check to this call, similar to the check in the code
> above.

I committed a slightly different change in git (without #ifdef, and I
left out the ass_track check - the code _showing_ subtitles doesn't have
such a check about ass_track actually existing, and AFAIK nothing should
add subtitles that need clearing if ass_enabled is set).




More information about the MPlayer-dev-eng mailing list