[MPlayer-dev-eng] [PATCH] Return actual current stream id in slave mode

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Dec 27 15:14:26 CET 2009


On Sun, Dec 27, 2009 at 01:49:56PM +0100, Reimar Döffinger wrote:
> On Wed, Dec 16, 2009 at 01:00:35AM +0100, Adrian Stutz wrote:
> > With a value of -2 it returns M_PROPERTY_UNAVAILABLE which is equivalent to
> > having no audio or video stream. I don't see much point of returning -2
> > instead and would rather improve the slave mode with printing the actual
> > error (it currently only says "Failed to get value of property
> > 'switch_audio'.").
> 
> Well, which you did with the other patch, but even with that when audio
> is disabled you would say "ANS_ERROR=UNAVAILABLE" when actually it is
> disabled which is just wrong (also, audio being disabled is not really
> an error in getting the current audio track, is it?).

I am not really sure how to handle this best, so for now I just changed
the parts I consider non-controversial.
It does mean that frontends would have to recognize and handle the == -1
and == -2 return values specially so far though.



More information about the MPlayer-dev-eng mailing list