[MPlayer-dev-eng] [PATCH] Fix 'make distclean'

[Uoti Urpala]

On Tue, 2009-02-03 at 01:00 +0200, Georgi Petrov wrote:
> I found the problem about help_mp.h not being deleted by "make
> distclean" under Windows.
> 
> When mplayer.exe is run from the svn root directory, it creates a
> sub-directory called "mplayer". Please note that if mplayer.exe is
> executed from MSYS environment it doesn't create the mplayer sub
> directory for some reason, but when executed from windows shell, it
> does. Then when "make distclean" is executed, there is the following
> line:
> 
> rm -f mplayer mencoder


> The fix is simple. Change
> 
> rm -f mplayer mencoder
> 
> to:
> 
> rm -rf mplayer mencoder
> 
> This ensures that make distclean cleans both the executable mplayer
> and the sub directory mplayer, so the command always succeeds.
> 
> I attach the patch.

If that line removes the subdirectory then what removes the executable?
Isn't the line supposed to take the executable suffix into account so
that it should attempt to remove the executable, not the directory? Why
does the existing $(EXESUF) which is visible in your patch too not do
that?