[MPlayer-dev-eng] [PATCH 0/9] Add AVR32 support and optimization to MPlayer
Diego Biurrun
diego at biurrun.de
Mon Feb 16 18:34:34 CET 2009
On Mon, Feb 16, 2009 at 05:57:05PM +0100, Diego Biurrun wrote:
> On Mon, Feb 16, 2009 at 05:16:49PM +0100, Hans-Christian Egtvedt wrote:
> >
> > The following 9 patches are my first attempt to send the AVR32 optimization of
> > MPlayer upstream.
>
> It's good to see Atmel do this. Unfortunately not all companies take
> this route.
>
> > All comments are welcome.
>
> First off, patches to FFmpeg, i.e. libavcodec, libavutil, libswscale,
> etc., should be sent to the ffmpeg-devel mailing list. I will post some
> comments anyway so that you can send improved patches there.
I suggest that you read
http://www.ffmpeg.org/general.html#SEC22
before you submit your patches to FFmpeg. All of the things mentioned
there should be addressed. Also, format your code in pretty K&R style
and fix all obvious deficiencies and break your patches into small
self-contained bits. The review process in FFmpeg is stringent, try to
address as many issues as possible beforehand.
Diego
More information about the MPlayer-dev-eng
mailing list