[MPlayer-dev-eng] [PATCH] internal dvdnav

[Reimar Döffinger]

On Thu, Jan 08, 2009 at 10:01:57PM +0200, Uoti Urpala wrote:
> On Thu, 2009-01-08 at 19:09 +0100, Reimar Döffinger wrote:
> > Ok, I will keep the discussion short:
> 
> I bit too short IMO, not leaving much chance to resolve anything or even
> find out exactly what the differences are.

Which I was not interested in. I had a patch, I will be using it, the
only immediately open question is if I should apply it, or not (or maybe
wait).
What the differences are:
I can debug libdvd* directly, with the same debug options/compile flags as
the MPlayer build I work with, gdb can find the source for the files (I
rarely use that though), it is statically linked so on Windows I can
just copy the binary to some other PC (note that also libdvdcss is
statically linked, libdvdread currently only supports that when
HAVE_DVDCSS_DVDCSS_H is defined manually), when I modify a file libdvd*
I only need to type make and wait a few seconds to test it.
If I want to do some bigger changes, I only need to do a MPlayer
checkout somewhere and it gets its own clean libdvd*.
I think that is about the advantages that will be relevant "regularly".
Obviously it is possible to get all this "somehow" without including it
directly, but given these are all projects with huge developer overlap I
do not see the need to avoid including it when it means extra effort,
and I hope/expect the distributions will make sure that compilation
against external libdvd* will stay functional.

Greetings,
Reimar Döffinger