[MPlayer-dev-eng] [PATCH] fix mencoder creates bad avi files when recording h264 in ts container from DVB

[Attila Kinali]

On Thu, 02 Jul 2009 16:11:21 +0400
vladisslav vladisslav <vladisslav at inbox.ru> wrote:

> > > > +   sh_video->disp_w=picture.display_picture_width;
> > > > +   sh_video->disp_h=picture.display_picture_height;
> > > 
> > > Any comments on this patch?
> > > It seems to be trival.
> > 
> > Well, if you are confident and tested it thoroughly, apply..
> > 
> I have used mplayer/mencoder (various svn builds) with this patch applied
> since January 2009 and got no problem. So i think it does not break anything.

The question isnt whether it breaks anything, but whether the patch is correct.
Although it might not break anything now, it might be still wrong and cause
problems later when something at a very different point is changed.

> The only problem it fixes is that sh_video members disp_w and disp_h does not
> get set properly when demuxing h264 stream in ps/es/ts This is not a problem
> when playing or trancoding a stream (decoder sets disp_w and disp_h correctly),
> but invalid values (zero whdth/height) get written into resulting avi file header
> in '-ovc copy' mode. Mplayer plays such files correctly, but some other programs
> crashes. I can provide test case: source ts and resulting broken avi if
> megaupload/rapidshare/mediafire is ok. Files are large - has to be at least
> 30-40Mb to be playable...

We should have enough sample files to reproduce, unless there are special
files required.

BTW: we have our own ftp server for uploads
BTW2: it's MPlayer, not Mplayer
BTW3: please limit your line length to 75 characters, especially when you
are using a webmail interface.


			Attila Kinali
-- 
If you want to walk fast, walk alone.
If you want to walk far, walk together.
		-- African proverb