[MPlayer-dev-eng] Multiple -vf-add on the command line (and probably other -list-add)

[Uoti Urpala]

On Sun, 2009-07-12 at 16:34 +0200, Adrian Stutz wrote:
> Attached is a patch the fixes the check if a match has been found,
> though that exposes two problems:
> * It's no longer possible to use two -*-add, even if that only worked unreliably
> * It more clearly exposes the overwrite bug which I haven't had time
> to find a fix for
> 
> Which brings me back to the original question: Should it be possible
> to use multiple -vf-add?

I think the intended behavior was to support it.

>  What would be the preferred way to add that
> to play_tree_set_param so that multiple of those list options don't
> get overwritten (the rest of the list handling seems to handle that
> just fine).

Depends on how much of the code you're going to clean up. The
option/playtree stuff is quite ugly overall, it looks like an attempt to
write "general" code done completely wrong.

Does something break if you just remove the code which prevents multiple
instances of the same option (the one which your patch "fixes")? It's
been a while since I looked at that code and I can't tell offhand
whether it would be likely to work.