[MPlayer-dev-eng] Remove libass

[Evgeniy Stepanov]

First of all, sorry for the late answer, my internet connection was down for 
almost a week :(

We discussed this idea with Grigori, and since he actively develops libass; 
and me, and nobody else here does not; and his version has some important 
improvements at this point, it really makes sense to make the project at 
code.google.com the official home of libass. Having libass as a separate, easily 
accessible standalone library will make people like vlc developers, 
distribution maintainers and others really happy :)

Unless someone volunteers to periodically merge patches from that project, I 
think mplayer should also switch to external libass.

More comments inline...

On Monday 27 July 2009 00:03:05 Diego Biurrun wrote:
> On Wed, Jul 22, 2009 at 12:55:42AM +0200, Grigori Goronzy wrote:
> > Diego Biurrun wrote:
> > >> There are a few possible problems.
> > >> * It's not possible to statically link libass into the mplayer binary
> > >> at the moment.
> > >
> > > Why?
> >
> > Mostly because it's not support by the build system yet.

Are there any real problems, or we just need to write some configure bits? If 
libass could be set up as an svn external, the proposal will become much more 
attractive.

> I consider this a dealbreaker for now.
>
> > >> +#ifndef LIBASS_MP_H
> > >> +#define LIBASS_MP_H
> > >
> > > This is not the correct multiple inclusion guard.
> >
> > Not my fault. :-)
>
> It is once you move the file.  Anyway, just fix it..
>
> > >> +typedef struct {
> > >> +    ass_image_t *imgs;
> > >> +    int changed;
> > >> +} mp_eosd_images_t;
> > >
> > > Please avoid _t typedefs, the _t namespace is reserved by POSIX.
> >
> > Not mine either.
>
> Please don't add further namespace pollution.  And you could fix libass.
> Avoiding namespace pollution is a good thing.
>
>
> Evgeniy is the maintainer of libass (in MPlayer).  He needs to decide
> the fate of this patch.
>
> Diego
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng