[MPlayer-dev-eng] [PATCH] Fix MPlayer to compile on Darwin/x86_86

[Reimar Döffinger]

On Sat, Jun 06, 2009 at 02:57:33PM +0200, Guillaume POIRIER wrote:
> On Tue, Jun 2, 2009 at 10:57 PM, Loren Merritt <lorenm at u.washington.edu>wrote:
> > On Tue, 2 Jun 2009, Loren Merritt wrote:
> >> On Tue, 2 Jun 2009, Guillaume POIRIER wrote:
> >>
> >>  I have not found where in Apple's doc that information is written.
> >>> However,
> >>> here's what one of Apple's engineer has responded to me about that
> >>> problem:
> >>>
> >>> This is a courtesy email regarding Bug ID# 6910963.
> >>> Engineering has provided the following feedback regarding this issue:
> >>> Thank you for the additional information.
> >>> The asm code is wrong for 64-bit.  The software needs porting to work.
> >>>  You
> >>> cannot use the "g" constraint for mov.  mov will take an "r" for example
> >>> of
> >>> a constraint that will work.
> >>>
> >>
> >> You can you a "g" constraint for mov; it supports 64bit immediates.
> >> But mov is the only such instruction. You can't use "g" constraint for
> >> cmp, if the value might not fit in int32.
> >>
> >
> > You can, however, use an "erm" constraint, which specifies the limit on
> > immediate size.
> >
> >
> Yep, that indeed works.Please find in attachment an update patch based on
> your feedback.

IMO feel free to apply the "erm" part. I haven't looked at it int that
much detail but it seems ok to me (probably "rm" would have been good
enough for this case to not cause a performance issue, too).