[MPlayer-dev-eng] [PATCH] vo_macosx: process events with shared_buffer (and patch roundup)

[Michael Guntsche]

On May 4, 2009, at 20:03, Adrian Stutz wrote:

> I think Michael's patch is sensible in this case, though I think it  
> also
> needs an autorelease pool so we don't leak any memory until MPlayer is
> closed. I haven't tested if it's the case for this specific NSApp  
> message
> but Cocoa generally expects an autorelease pool to be in place.
>

Thanks for looking into this. I do not think we need an autorelease  
pool in this special case though,
since we are not doing an initwith or similar at all. NSApp is already  
there and we are just using it in this case.
Also keep in mind that in your implementation right now the  
autorelease pool is created and deleted in the checkEvents function,  
while NSApp exists as long as the mplayer NSTask is running.
So I really do not think that we are leaking anything here without an  
autorelease pool.

Kind regards,
Michael