[MPlayer-dev-eng] [PATCH] Add DVB teletext support

Francesco Lavra francescolavra at interfree.it
Tue Nov 3 19:36:55 CET 2009


On Tue, 2009-11-03 at 16:16 +0000, Carl Eugen Hoyos wrote:
> Francesco Lavra <francescolavra <at> interfree.it> writes:
> 
> > +#ifdef CONFIG_TV_TELETEXT
> >  int teletext_control(void* p, int cmd, void *arg);
> > +#else
> > +#define teletext_control(p, cmd, arg) VBI_CONTROL_FALSE
> > +#endif
> 
> Is this necessary?
> I mean, can't we just compile dec_teletext.c unconditionally?
> 
> Carl Eugen

Yes, we can compile it unconditionally, that would mean getting rid of
configuration options like --enable-tv-teletext. I don't see any problem
in doing it.
Another possibility would be to change the current "auto-detection"
feature of the configure script in such a way that it enables teletext
not only when tv_v4l and alike are present, but also when DVB is there.
Let me know what you prefer.
Francesco




More information about the MPlayer-dev-eng mailing list