[MPlayer-dev-eng] [PATCH] ffvorbis surround broken

[Reimar Döffinger]

On Fri, Oct 30, 2009 at 10:15:20PM +0100, Nicolas George wrote:
> Le nonidi 9 brumaire, an CCXVIII, Nicolas George a écrit :
> > Channel order is currently broken with ffvorbis. It probably has been since
> > 2009-10-02 r20148 "Add vorbis channel layout support".
> > 
> > The attached trivial patch fixes it.
> > 
> > As far as I understand, lavc is progressively converting all its codecs to
> > output in the WAVE order, so it will probably make sense to change
> > AF_CHANNEL_LAYOUT_LAVC_DEFAULT in a near future, but note quite yet.
> 
> And I realize that AF_CHANNEL_LAYOUT_LAVC_DEFAULT was already equivalent to
> the WAVE order.
> 
> Therefore, the simpler attached patch fixes both ffvorbis and ffaac.
> 
> Please note that you can not produce speaker_test_6.aac from
> speaker_test_6.ogg using ffmpeg, as the channel ordering is currently broken
> for libfaac. I used mencoder and the -audiofile option to produce an AVI
> file with an AAC track.

Who has been handling/applying the other multichannel fixes?
If there's not obvious issue with this change I guess it should be applied,
but I don't have the hardware to really test it easily.