[MPlayer-dev-eng] [PATCH] fix length in asf files

[Reimar Döffinger]

On Tue, Nov 10, 2009 at 05:48:55PM -0500, compn wrote:
> On Tue, 10 Nov 2009 18:43:24 +0100, Reimar Döffinger wrote:
> >On Tue, Nov 10, 2009 at 10:07:48AM -0500, compn wrote:
> >> asfheader-force_best_stream.diff
> >
> >Will probably break mms in many cases, since the "best" stream
> >this selects might not actually be available.
> 
> i thought mms code had its own auto-selection. at least this wmv
> feature request is here:
> http://bugzilla.mplayerhq.hu/show_bug.cgi?id=427

Yes, but this code adds another auto-selection in the demuxer which
might end up selecting one of the streams that the stream layer
disabled, thus waiting forever for data to arrive.
This issue is one of the reasons why demuxer lavf does not work with
mms.

> >> vd_ffmpeg-restrict_dimension_correction.diff
> >
> >No idea at all. Part of the patch is for lavf though...
> 
> related to this issue?
> http://roundup.ffmpeg.org/roundup/ffmpeg/issue32

No idea, I didn't really understand the patch.

> >> vd_qtvideo-validate_ImageDesc_size.diff
> >
> >yes, unfortunately lavf does not give us everything necessary to use QT
> >binary decoders :-(
> i wonder if it fixes:
> http://roundup.ffmpeg.org/roundup/ffmpeg/issue1322
> http://roundup.ffmpeg.org/roundup/ffmpeg/issue1320

It doesn't really fix anything for what I can tell, it just detects the
situation and aborts (which means no crash but not a working video
either).