[MPlayer-dev-eng] [PATCH] 8 channel support for ao_dsound

[Jason Tackaberry]

Hi,

On Thu, 2009-11-12 at 10:19 +0800, william0wang wrote: 
> The attached patch is to add 8 channel support for ao_dsound. It works
> fine on Realtek ALC1200 and windows 7.

Can you confirm that by "works" you mean the channel order is correct?
Have you tested with a wav file that speaks the channel names, or some
other similarly reliable method.


> +  SPEAKER_FRONT_LEFT   | SPEAKER_FRONT_CENTER | SPEAKER_BACK_CENTER  | SPEAKER_FRONT_RIGHT  | SPEAKER_BACK_LEFT      | SPEAKER_BACK_RIGHT     | SPEAKER_LOW_FREQUENCY,
> +  SPEAKER_FRONT_LEFT   | SPEAKER_FRONT_CENTER | SPEAKER_FRONT_RIGHT  | SPEAKER_BACK_RIGHT   | SPEAKER_BACK_LEFT      | SPEAKER_SIDE_RIGHT     | SPEAKER_SIDE_LEFT      | SPEAKER_LOW_FREQUENCY

It's cosmetic, but these don't appear to be in any specific order.  The
existing ones don't seem to be either, mind you.  I'd prefer they all be
listed in the WAVEEX order (the order of the defines at the top of the
file).

Could you at least modify your patch to list the 7 and 8 channel masks
to be in that order?  I can take care of the other ones later.


>         //check if the channel count and format is supported in general
> -       if (channels > 6) {
> -               UninitDirectSound();
> -               mp_msg(MSGT_AO, MSGL_ERR, "ao_dsound: 8 channel audio not yet supported\n");
> -               return 0;
> -       }

Please also adjust the comment to reflect the fact that channel count is
not being checked.

Otherwise, the patch is clean and simple, happily.

Thanks,
Jason.