[MPlayer-dev-eng] [PATCH v2] Mac OS X: fix compilation on Mac OS X 10.4

Diego Biurrun diego at biurrun.de
Tue Oct 6 00:05:31 CEST 2009


On Tue, Oct 06, 2009 at 12:14:35AM +0300, Aaro Koskinen wrote:
> 
> On 5.10.2009, at 21.59, Adrian Stutz wrote:
> >2009/10/5 Aaro Koskinen <aaro.koskinen at iki.fi>:
> >>I don't think the SDK provides any information on which version we
> >>are compiling with.
> >
> >There's an Apple Tech Note explaining how to compile for different  
> >SDKs:
> >http://developer.apple.com/mac/library/documentation/DeveloperTools/ 
> >Conceptual/cross_development/Using/using.html
> 
> Thanks.
> 
> >The example uses the __ prefixed defines, which are only available
> >from 10.5 in Availability.h. To compile on 10.4 you'll have to use
> >MAC_OS_X_VERSION_MIN_REQUIRED from AvailabilityMacros.h instead.
> 
> Hmm, I think you mean:
> 
> #if MAC_OS_X_VERSION_MAX_ALLOWED <= 1040
> ...
> #define keycodes
> ...
> #endif
> 
> A refreshed patch is attached.
> 

> --- libvo/osx_common.c.orig	2009-09-05 11:48:48.000000000 +0300
> +++ libvo/osx_common.c	2009-10-05 23:30:54.000000000 +0300
> @@ -24,6 +24,59 @@
>  #include "osdep/keycodes.h"
>  #include "input/input.h"
>  
> +#if defined(MAC_OS_X_VERSION_MAX_ALLOWED)
> +#if MAC_OS_X_VERSION_MAX_ALLOWED <= 1040

These two look redundant.

Diego



More information about the MPlayer-dev-eng mailing list