[MPlayer-dev-eng] [PATCH] Add support for ARIB STD-B24 captions v4

[Michael Wu]

>> --- sub_arib.h	(revision 0)
>> +++ sub_arib.h	(revision 0)
>> @@ -0,0 +1,27 @@
>> +
>> +#ifdef CONFIG_ARIB
>> +
>> +#include "libass/ass_mp.h"
>> +
>> +void arib_process_data_group(unsigned char *data, int len, double
>> subpts, ass_track_t *track);
>> +
>> +#else
>> +
>> +void arib_process_data_group(unsigned char *data, int len, double
>> subpts, void *track) {};
>> +
>> +#endif /* CONFIG_ARIB */
>
> This #ifdeffery is extremely ugly and unacceptable.
>
How do you prefer compiling out features then? You didn't like taking out
the function call with CONFIG_ARIB and you don't like making the function
do nothing. How exactly do you want arib_process_data_group to be handled
if CONFIG_ARIB is off?

-Michael Wu