[MPlayer-dev-eng] [PATCH] vobsub missing subs

[ubitux]

On Wed, Apr 14, 2010 at 08:54:37AM +0000, Carl Eugen Hoyos wrote:
> ubitux <ubitux <at> gmail.com> writes:
> 
> > In fact, it seems that those packets are simply not padded with padding
> > packets. So here is a patch which seems to work to handle the issue.
> 
> Are the two variables needed?
> 

I think it's safer this way: I could use only one variable which is only
reset in the vobsub_open loop, but this is not a good idea since we are
not sure to enter the merge condition for each processed packet.

With two variable, the mpeg_run controls totally if packets have to be
merged or not. I don't think vobsub_open should have "write access" to
that kind of information.

> > As the issue is fixed, I just removed a dead code in spudec which was
> > another hack to partially fix the issue.
> 

Oh, sorry.

> Applied. Please try to keep issues separated.
> 
> Carl Eugen

-- 
ubitux