[MPlayer-dev-eng] [PATCH] Coreaudio patches (audio device selection and deprecated functions)

[Reimar Döffinger]

On Wed, Apr 21, 2010 at 11:33:22PM +0200, Adrian Stutz wrote:
> On Wed, Apr 21, 2010 at 14:27, Diego Biurrun <diego at biurrun.de> wrote:
> >> Uh, I don't know what's the best way to handle it. They way I went
> >> with was to stick to whatever type the API is using.
> >> If you prefer the POSIX types, I can change them.
> >
> > The file already uses POSIX types in some places...
> 
> Well, I didn't write it and it's not like it's hyper consistent...
> 
> To clarify what I meant: I used whatever type the CoreAudio,
> AudioUnits, CoreFoundation APIs are using in their methods.
> 
> I don't mind either way. If you think it's better to use POSIX types
> wherever possible then I can change it. I can also clean up the file
> afterwards to make it consistent.

When it's used with API functions I think it's better to keep the types the
API uses, even though I consider it ugly.