[MPlayer-dev-eng] [RFC] EOSD improvements

[Reimar Döffinger]

On Mon, Aug 02, 2010 at 08:16:08PM +0200, Nicolas George wrote:
> Le quintidi 15 thermidor, an CCXVIII, Reimar Döffinger a écrit :
> > Though there might still be a problem due to the OSD having multiple
> > parts and then there's the EOSD and I think they're all supposed to be
> > merged together to one single EOSD command.
> > It might be not too hard due to the way the OSD works, but honestly I
> > don't have it all in my head so I would really know.
> 
> With the way EOSD works at this time, it is just impossible: there is no
> EOSD command carrying the overlay data: when VFCTRL_DRAW_EOSD is triggered,
> it calls ass_mp_render_frame to get the overlay data to render.

Sorry for the confusion, I was thinking of the VOCTRL_DRAW_EOSD, which I
think may be a good model to base things on.

> Here is my suggestion:
> 
> Patch #1: make EOSD data flow in a single direction, disentangling EOSD from
>           libass, and factoring some redundant code in the process.

The problem here is with pts handling. One of the desired features was
that the filter's pts would be used to e.g. with frame-doubling filters
animated ASS content would become smoother, too (not that it is working
really right in current SVN, but at least the vf_ass design would allow
it).
I don't have any great idea for how to best solve this right now.
Maybe add an argument to VFCTRL_DRAW_EOSD and make the vf_ass filter
just append the stuff from the ASS subtitles? (and generate completely
anew if the argument is NULL, thus keeping almost 100% compatibility
to the current code).