[MPlayer-dev-eng] [PATCH]Fix --disable-tremor-internal

Diego Biurrun diego at biurrun.de
Tue Aug 3 00:30:50 CEST 2010


On Mon, Aug 02, 2010 at 08:45:58PM +0200, Reimar Döffinger wrote:
> On Sun, Aug 01, 2010 at 10:03:54PM +0000, Carl Eugen Hoyos wrote:
> > Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > 
> > > Well, it means it won't work anymore on systems that do
> > > have a non-split libvorbis, nor will it work on systems
> > > with only decoder installed.
> > 
> > I understand.
> > So can I commit the following inlined as a start?
> > 
> > --- configure   (Revision 31890)
> > +++ configure   (Arbeitskopie)
> > @@ -6665,7 +6665,6 @@
> >    codecmodules="libvorbis $codecmodules"
> >    res_comment="libvorbis"
> >    extra_ldflags="$extra_ldflags -lvorbis -logg"
> > -  libavencoders="$libavencoders LIBVORBIS_ENCODER"
> 
> Wouldn't that mean that encoding with libvorbis will not at
> all be possible anymore?
> Seems at least suboptimal, but I don't care much.

That's what it looks like to me as well.  Since you add the flags that
are used by FFmpeg's configure, I think your original patch is OK.

Diego


More information about the MPlayer-dev-eng mailing list