[MPlayer-dev-eng] [PATCH] Correctly detect sockaddr_storage on OpenBSD

Diego Biurrun diego at biurrun.de
Thu Aug 5 09:48:49 CEST 2010


On Tue, Aug 03, 2010 at 03:08:52PM +0100, Edd Barrett wrote:
> <sys/socket.h> requires <sys/types.h> on OpenBSD.
> 
> --- configure	(revision 31912)
> +++ configure	(working copy)
> @@ -3266,6 +3266,9 @@
>  #if HAVE_WINSOCK2_H
>  #include <winsock2.h>
>  #else
> +#ifdef __OpenBSD__
> +#include <sys/types.h>
> +#endif
>  #include <sys/socket.h>
>  #endif

Such #ifdefs are evil and must be avoided at all cost.

I have added the header unconditionally, we have it in all other
configure tests before socket.h.

Diego


More information about the MPlayer-dev-eng mailing list