[MPlayer-dev-eng] [RFC] libavutil/x86_cpu.h

[Diego Biurrun]

On Fri, Aug 06, 2010 at 09:03:16PM +0200, Reimar Döffinger wrote:
> On Fri, Aug 06, 2010 at 06:21:29PM +0200, Diego Biurrun wrote:
> > On Fri, Aug 06, 2010 at 06:05:50PM +0200, Reimar Döffinger wrote:
> > > But your suggestion does not help anything there, it just changes
> > > the requirement of having a libavutil/x86_cpu.h in the source tree
> > > to instead have a x86_cpu.h in the source tree that we due to SVN's
> > > shortcomings also have to update manually.
> > 
> > No updating will be necessary.  FFmpeg will continue to use its own
> > copy in libavutil/ regardless of whether or not we have it elsewhere.
> > 
> > On the contrary, if libavutil/x86_cpu.h changes, our local code will
> > not have to be modified because it will continue to use the stable
> > header under our control.
> > 
> > That said, I do not expect many changes to this header file, much
> > less changes that might be worth porting over.
> 
> That is only true as long as the names of the defines do not
> change.

Umm, what?  The names of the defines only change when you change them.
In FFmpeg they can change all they want, we will be unaffected.  If you
change them in MPlayer, of course you will have to adapt MPlayer to it.

> Also it is only an argument that it's not much worse, I
> still fail to see any advantage.

No more dependency on libavutil in the source tree.

Diego