[MPlayer-dev-eng] [patch] backports/fixes from uoti demux_mkv.c for comp_algo==3

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Aug 12 21:55:10 CEST 2010


On Thu, Aug 12, 2010 at 11:43:26PM +0400, Yuriy Kaminskiy wrote:
> Yuriy Kaminskiy wrote:
> > Reimar Döffinger wrote:
> >> On Thu, Aug 12, 2010 at 09:33:40PM +0400, Yuriy Kaminskiy wrote:
> >>> +        } else if (track->encodings[i].comp_algo == 3) {
> >>> +            modified = 1;
> >>> +            *dest = malloc(*size + track->encodings[i].comp_settings_len);
> >> Integer overflow?
> > No different from zlib code just above? (and a lot code nearby)
> > And there are already allocation for both *size and comp_settings_len.
> > Anyway, updated patches attached (and one more to follow later...)
> Not sure if that is all (and some maybe unnecessary; or solved in more nice
> way), but here it is. On top of "full" series.

I'm not going to review it in detail, but both patches seem
to be an improvement.
If the maintainer/author does not speak up any time soon
I think these should be applied.


More information about the MPlayer-dev-eng mailing list