[MPlayer-dev-eng] [patch] backports/fixes from uoti demux_mkv.c for comp_algo==3

[Aurelien Jacobs]

On Thu, Aug 12, 2010 at 09:33:40PM +0400, Yuriy Kaminskiy wrote:
> Minimal series:
> min.01) Support comp_algo==3;

Why ? What is your reason to use the old unmaintained demux_mkv.c ?
It is not used by default anymore, and demux_lavf (the default mkv
demuxer) has full support of comp_algo==3 (and comp_algo==1) for any
kind of tracks (including all kind of subtitles).
Do you plan to send more patches to actually bring demux_mkv.c to the
same level of feature than demux_lavf ?

> min.02) Fix leak with lzo (there are another unfixed leak possible!)

demux_mkv.c is full of potential mem leak, integer overflow, null
pointer deference and so on.
Fixing them all would be quite some work (IMHO not worth at all).
Fixing just one is not much helpfull...

> > >> +        } else if (track->encodings[i].comp_algo == 3) {
> > >> +            modified = 1;
> > >> +            *dest = malloc(*size +
> > track->encodings[i].comp_settings_len);
> > >
> > > Integer overflow?
> > No different from zlib code just above? (and a lot code nearby)
> 
> That, unfortunately, is more an argument for disabling
> the native demuxer than for the patch...

The fact that it is not used by default should be good enough IMHO, but
if you want to totally disable it, feel free. It indeed contains many
potential security issues.

Aurel