[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

Nicolas George nicolas.george at normalesup.org
Sat Aug 14 11:50:26 CEST 2010


Hi.

The attached patch factors some code that was duplicated between vf_ass and
vf_vo.

Notes:

- The diffstat shows +54 overall, which as factorizations go is rather
  lousy. But most of them are caused by my choice to create a new source
  file and a new header file: huge license blob, double-inclusion guards,
  #includes, etc. I counted that the balance for actual lines of code is
  -47+38 = -9.

- Tested with vo_gl but not with vo_vdpau; since the changes are in the
  common upstream of both, there is no reason for it to break.

- A cosmetic patch to wrap long lines kept from the original code may
  follow if deemed necessary.

- Apart from slightly simplifying the current code, these changes should
  make it much easier to add new overlay sources in the future.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-factor-20100814.diff
Type: text/x-diff
Size: 10620 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/9e127bc1/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/9e127bc1/attachment.pgp>


More information about the MPlayer-dev-eng mailing list