[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

[Reimar Döffinger]

On Sat, Aug 14, 2010 at 12:42:28PM +0200, Nicolas George wrote:
>  	case VFCTRL_DRAW_EOSD:
> -		if (vf->priv->ass_priv) return CONTROL_TRUE;
> +		return CONTROL_TRUE;
>  		break;

The break is now pointless.

> +        if (!vo_config_count) return CONTROL_FALSE;
> +        mp_eosd_res_t res;
> +        memset(&res, 0, sizeof(res));

Could you put the declaration before any statement?
Also here and in the other place
mp_eosd_res_t res = {0};
should be a nicer way to initialize.
Apart from that I haven't really looked in detail,
so I don't know if it's actually going to have much of
an advantage, but it's fine for me if you think it helps
for the next steps (in terms of code simplification it
doesn't seem like much of an improvement).