[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Reimar Döffinger]

On Thu, Aug 19, 2010 at 11:24:05AM +0200, Pásztor Szilárd wrote:
> > > -    if (correct_pts && pts != MP_NOPTS_VALUE) {
> > > +    mpi = mpvdec->decode(sh_video, start, in_size, drop_frame);
> > > +    if (mpi && mpi->type == MP_IMGTYPE_NULL) {
> > 
> > Well, I guess it is possible this somehow happens
> > to be the right thing to check (though I have some
> > doubts) but even then that's unintentional
> > and might break at any time.
> > How did you come up with the idea of using that?
> 
> Could you explain in more detail what you are referring to?
> This is intentionally "the right thing" to check because I purposely added
> this image type and it won't break until someone breaks it.

I missed it.
You just used it for !got_picture, however that doesn't help any,
got_picture will be 0 regardless of whether the frame was skipped
because it is a single field or for some other reason.
Libavcodec to my knowledge just does not provide that information,
which is why I was surprised how this was supposed to work.
And btw. you said that the patch gets the information from the
"parser", however it seems to only get information from the
decoder, the parser is either part of the demuxer or comes in-between
the demuxer and the decoder.