[MPlayer-dev-eng] [PATCH] unified timing patch for H264

Pásztor Szilárd don at tricon.hu
Sat Aug 21 12:37:10 CEST 2010


On Sat, 21 Aug 2010 08:24:35 +0200, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
>>          if (cur->field_poc[0]==INT_MAX || cur->field_poc[1]==INT_MAX) {
>>              /* Wait for second field. */
>> -            *data_size = 0;
>> +            *data_size = -1;
> 
> You can't use it like that, that's a size field and setting it like
> this would mean *data points to almost 4 GB of data - at least unless
> you change the API which requires a major verson bump, and that
> won't happen so soon.
> That's why I suggested changing the return value.

Ok, here it is corrected. I introduced -2 as retval.
Magic numbers are not nice, but that's how it is in
lavc anyway.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer-h264-timing-20100820.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100821/23d70868/attachment.asc>


More information about the MPlayer-dev-eng mailing list