[MPlayer-dev-eng] [PATCH] RFC: CrystalHD decoder support

[Reimar Döffinger]

On Sun, Dec 19, 2010 at 06:50:04PM -0700, Philip Langdale wrote:
> @@ -9,6 +9,135 @@ release 20101127
>  ;                   VIDEO CODECS
>  ;=============================================================================
>  
> +videocodec chdh264
> +  info "CrystalHD H.264"
> +  status working
> +  fourcc H264,h264
> +  fourcc X264,x264
> +  fourcc avc1,AVC1
> +  fourcc davc,DAVC
> +  fourcc vvvc ; only one sample using this fourcc
> +  format 0x10000005
> +  driver crystalhd
> +  dll crystalhd
> +  out YUY2
> +
> +videocodec chdmpeg1
> +  info "CrystalHD MPEG-1"
> +  status working
> +  format 0x10000001  ; MPEG-1
> +  fourcc mpg1
> +  fourcc PIM1        ; Pinnacle hardware-MPEG-1
> +  fourcc VCR2
> +  fourcc MPEG
> +  fourcc m1v1
> +  driver crystalhd
> +  dll crystalhd
> +  out YUY2

If you are porting it to FFmpeg that is pretty much irrelevant, but I
just realize that you are using the "videcodec" name to decide which decoder
to use. That is a bad idea, since that is user-visible and we should be
able to change that without changing program behaviour.
You should instead change the "dll" as it is done for all FFmpeg
decoders for example.