[MPlayer-dev-eng] [PATCH] Multiple problems with tfields filter

[Uoti Urpala]

On Sun, 2010-01-31 at 23:23 +0100, Reimar Döffinger wrote:
> On Sun, Jan 31, 2010 at 04:34:47PM -0500, John Lindgren wrote:
> > By the way, MPlayer's manual page needs updating.  Contrary to the
> > manual page, tfields *does* work in MPlayer, not only MEncoder, and does
> > not need the -fps command line switch to work correctly.
> 
> Not really, it just happens to work if your vo does vsync and the vsync
> frequency is about twice the original frame rate.
> Might be good enough for most, but calling it "work" is a bit of a stretch.

It has worked better than that if -correct-pts is active since my commit
that enabled video filters to add frames back in 2006 (svn r18922),
though the filter doesn't implement exact pts calculation for the added
frames (just adds that 0.02 seconds to last frame pts). Since he
modified the value added to pts I think the behavior is probably exactly
right for his particular videos. In git behavior even without
-correct-pts is better now in the sense that you can at least frame step
over the added frames individually, though in that case they don't have
any individual pts generation (in svn it'll jump over both frames at
once).