[MPlayer-dev-eng] [Patch] fix ivtv cvidix in configure-script

[Reimar Döffinger]

Diego handles configure, but:
> -  # FIXME: ivtv driver temporarily disabled until we have a proper test
> -  #test "$_vidix_drivers" || _vidix_drivers="cyberblade ivtv mach64 mga mga_crtc2 nvidia pm2 pm3 radeon rage128 s3 sh_veu sis unichrome"
> +  echocheck "ivtv vidix driver"
> +  cat > $TMPC << EOF
> +#include <stdlib.h>
> +#include <inttypes.h>
> +#include <linux/types.h>
> +#include <linux/videodev2.h>
> +#include <linux/ivtv.h>
> +#include <sys/ioctl.h>
> +int main(void) {
> +struct ivtv_dma_frame tmp;
> +tmp.type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
> +ioctl(0, IVTV_IOC_DMA_FRAME, &tmp);
> +return 0; }
> +EOF
> +  _vidix_drv_ivtv=no
> +  cc_check && _vidix_drv_ivtv=yes
> +
>    test "$_vidix_drivers" || _vidix_drivers="cyberblade mach64 mga mga_crtc2 nvidia pm2 pm3 radeon rage128 s3 sh_veu sis unichrome"
> +  if test "$_vidix_drv_ivtv" = yes ; then
> +    _vidix_drivers="ivtv $_vidix_drivers"
> +  fi
> +  echores "$_vidix_drv_ivtv"

Don't put enabling the other drivers in the middle of the ivtv detection.
And for new variables you should not use _ at the start of the variable names.
Proper indenting of the code in main probably wouldn't hurt either.

> diff -ur mplayer-old/vidix/ivtv_vid.c mplayer-new/vidix/ivtv_vid.c
> --- mplayer-old/vidix/ivtv_vid.c	2010-01-24 19:06:43.277260784 +0100
> +++ mplayer-new/vidix/ivtv_vid.c	2010-01-24 19:18:11.977259993 +0100

Is that part actually necessary? Why?
2.6.22 is not that old that the code to support version before it should be
dropped unless it is really necessary (on thinking again it might actually
be that old, still...).