[MPlayer-dev-eng] [PATCH] Support CineForm DirectShow codec

[Steinar H. Gunderson]

On Tue, Feb 09, 2010 at 08:51:08PM +0100, Reimar Döffinger wrote:
> The "unlocking unlocked", "deleting unlocked" etc. ones.

You mean “deleting locked”, right?

> They are broken for several use-cases, not taking into account nested
> lockings it seems (which actually means the whole implementation
> probably is broken for that case), still...

Any reason why you wouldn't simply use Helgrind or another pthreads debugger
for that?

In any case, IMNSHO working locks with no debugging > broken locks with
broken debugging :-)

> Well, a semaphore is somewhat more complex, but it could be used.
> Though the current semaphore code can not easily be reused it seems.

No, it would have to be a separate implementation. Also, there are bugs in
the semaphore implementation as well, although perhaps none that are relevant
for the critical section implementation (IIRC they're in WaitForSingleObject).

/* Steinar */
-- 
Homepage: http://www.sesse.net/