[MPlayer-dev-eng] [PATCH] -vobsub support for mencoder

[Uoti Urpala]

On Wed, 2010-02-10 at 04:56 +0100, Gianluigi Tiesi wrote:
> I'm working on moving some of mplayer subtitle code in mpcommon
> and make mencoder use it.
> 
> The attached patch should not be considered as final
> but I would to post to have some feedbacks / corrections
> 
> Yes a better way would be vf_vobsub.c, it looks not trivial
> to reuse the current vobsub code (I'm not so expert in frame processing tough)

This is a bad idea. You shouldn't tie more code to the mess in MEncoder.

If you really need more functionality then a more sound approach is to
add the encoding functionality you need to MPlayer (start from MPlayer
with vo yuv4mpeg and add the encoding functionality you need, instead of
starting from MEncoder and trying to fix it).