[MPlayer-dev-eng] [PATCH] -vobsub support for mencoder

Diego Biurrun diego at biurrun.de
Wed Feb 10 10:29:07 CET 2010


On Wed, Feb 10, 2010 at 04:56:37AM +0100, Gianluigi Tiesi wrote:
> 
> are declared in mp_core.h instead of mpcommon.h
> even if functions body are in mpcommon.c
> this avoid inclusion of mp_core.h in mpcommon.h
> (command.c will complain about some stuff not defined)
> but feel free to move away

That's a hack, declare them in the appropriate place.

> --- main/mencoder.c	2010-01-31 00:30:08.750000000 +0100
> +++ sherpya/mencoder.c	2010-02-10 04:45:44.203125000 +0100
> @@ -532,38 +547,38 @@ play_next_file:
>  
> -  mp_msg(MSGT_CPLAYER, MSGL_INFO, MSGTR_OpenedStream, file_format, (int)(stream->start_pos), (int)(stream->end_pos));
> +  mp_msg(MSGT_CPLAYER, MSGL_INFO, MSGTR_OpenedStream, mpctx->file_format, (int)(mpctx->stream->start_pos), (int)(mpctx->stream->end_pos));

Maybe you could break such long lines if you are changing them anyway.

Diego



More information about the MPlayer-dev-eng mailing list