[MPlayer-dev-eng] [PATCH] -vobsub support for mencoder

[compn]

On Wed, 10 Feb 2010 17:37:08 +0100, Gianluigi Tiesi wrote:
>On Wed, Feb 10, 2010 at 06:43:13AM +0200, Uoti Urpala wrote:
>> On Wed, 2010-02-10 at 04:56 +0100, Gianluigi Tiesi wrote:
>> > I'm working on moving some of mplayer subtitle code in mpcommon
>> > and make mencoder use it.
>> > 
>> > The attached patch should not be considered as final
>> > but I would to post to have some feedbacks / corrections
>> > 
>> > Yes a better way would be vf_vobsub.c, it looks not trivial
>> > to reuse the current vobsub code (I'm not so expert in frame processing tough)
>> 
>> This is a bad idea. You shouldn't tie more code to the mess in MEncoder.
>> 
>> If you really need more functionality then a more sound approach is to
>> add the encoding functionality you need to MPlayer (start from MPlayer
>> with vo yuv4mpeg and add the encoding functionality you need, instead of
>> starting from MEncoder and trying to fix it).
>> 
>
>you cannot encode faster than realtime this way, or I'm wrong?

you are wrong, it should work about the same way as -ao pcm -benchmark

but are we sure that starting over and adding a bunch of code to mplayer
is the right way to do it ? if we are to drop mencoder, why not just
focus on getting binary codec support into ffmpeg?

and if mencoder is unmaintained and no one cares about it, then i say
apply these patches forthwith! end end these endless discussions about
killing mencoder. lets see you rm -rf it in git first!

-compn