[MPlayer-dev-eng] Crash in update_subtitles when audio only stream but with subtitles

Gianluigi Tiesi mplayer at netfarm.it
Sat Feb 13 12:08:27 CET 2010


On Sat, Feb 13, 2010 at 12:05:48PM +0100, Gianluigi Tiesi wrote:
> When an audio only clip (or the vo/vc failed to init)
> 
> mplayer tries to update anyway subtitles:
> 
> at line 3776:
> update_subtitles(NULL, a_pos, mpctx->d_sub, 0);
> 
> in "/*========================== PLAY AUDIO ============================*/"
> 
> in mpcommon.c:
> void update_subtitles(sh_video_t *sh_video, double refpts, demux_stream_t *d_dvdsub, int reset)
> ...
> 
>         spudec_heartbeat(vo_spudec, 90000*sh_video->timer);
> 
> but sh_video is NULL
> 

I think there is no point to:
  update_subtitles(NULL, a_pos, mpctx->d_sub, 0);
  update_osd_msg();

when mpctx->sh_video is NULL
I don't known about gui (if osd msg can be updated anyway)


-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/



More information about the MPlayer-dev-eng mailing list