[MPlayer-dev-eng] [PATCH] allow make -r to work

Diego Biurrun diego at biurrun.de
Tue Feb 16 14:20:08 CET 2010


On Tue, Feb 16, 2010 at 03:35:33AM +0100, Gianluigi Tiesi wrote:
> On Mon, Feb 15, 2010 at 11:01:20PM +0100, Reimar D?ffinger wrote:
> > we currently rely on several implicit rules, so make -r actually does
> > not compile at all.
> > Patch below fixes the cases I know of, any objections?
> > Index: Makefile
> > ===================================================================
> > --- Makefile	(revision 30589)
> > +++ Makefile	(working copy)
> > @@ -836,6 +836,15 @@
> >  %.ho: %.h
> >  	$(CC) $(CFLAGS) -Wno-unused -c -o $@ -x c $<
> >  
> > +%.o: %.S
> > +	$(CC) $(ASFLAGS) -c -o $@ $<
> > +
> > +%.o: %.c
> > +	$(CC) $(CFLAGS) -c -o $@ $<
> > +
> > +%.o: %.cpp
> > +	$(CC) $(CXXFLAGS) -c -o $@ $<
> > +
> >  %.o: %.m
> >  	$(CC) $(CFLAGS) -c -o $@ $<
> >  
> 
> I still have problems on msys with the -rc.o rule
> %-rc.o: %.rc
>     $(WINDRES) -I. $< $@
> 
> 
> gcc osdep/mplayer.rc.o   -o osdep/mplayer.rc
> gcc.exe: osdep/mplayer.rc.o: No such file or directory
> gcc.exe: no input files
> make: *** [osdep/mplayer.rc] Error 1

Is that with HEAD or with Reimar's patch applied?  What happens if you
move the .rc rule up (to line 864) in the Makefile?

Diego



More information about the MPlayer-dev-eng mailing list